-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flagd): Add in-process evaluator #104
feat(flagd): Add in-process evaluator #104
Conversation
2db5904
to
e826b3d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 93.91% 94.13% +0.21%
==========================================
Files 15 17 +2
Lines 789 903 +114
==========================================
+ Hits 741 850 +109
- Misses 48 53 +5 ☔ View full report in Codecov by Sentry. |
8a15f87
to
36269b5
Compare
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Outdated
Show resolved
Hide resolved
36269b5
to
af0df41
Compare
ca544a4
to
c68da7b
Compare
no more e2e tests are skipped 🎉 |
cae988c
to
87c50a4
Compare
LEEEETSS GOOOOO! |
The only issue I found is that the enum for the |
I merged all the previous work, and updated the implementation to match our latest findings regarding grpc. - there is room for improvements, eg. removing duplication between rpc and in-process for grpc connection etc. but i do think, this is something we can do in another step. should i open a new pull request, or will we continue from here? |
8945ff2
to
77b9eb8
Compare
77b9eb8
to
75a2659
Compare
3a28e78
to
622208b
Compare
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/tests/e2e/inprocess/test_flaqd.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one minor comment about the log level but don't want to block this.
d00cf69
to
78c8fd5
Compare
Co-authored-by: Cole Bailey <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
b8d3886
to
1a81305
Compare
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
1a81305
to
3ca43a4
Compare
.. updated test-harness to also check for selector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looks good 🍻
With these changes, we're adding in-process evaluation to the python flagd sdk. The whole e2e test-harness suite is passing, except the cases for unix socket and targetURI which are not implemented