Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagd): Add in-process evaluator #104

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Nov 18, 2024

With these changes, we're adding in-process evaluation to the python flagd sdk. The whole e2e test-harness suite is passing, except the cases for unix socket and targetURI which are not implemented

@toddbaert toddbaert changed the title [draft] syng pr with gherkin and testcontainers [draft] sync pr with gherkin and testcontainers Nov 18, 2024
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch from 2db5904 to e826b3d Compare November 19, 2024 06:47
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (4251f36) to head (3ca43a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../flagd/resolvers/process/connector/grpc_watcher.py 94.17% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   93.91%   94.13%   +0.21%     
==========================================
  Files          15       17       +2     
  Lines         789      903     +114     
==========================================
+ Hits          741      850     +109     
- Misses         48       53       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 3 times, most recently from 8a15f87 to 36269b5 Compare November 23, 2024 12:55
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch from 36269b5 to af0df41 Compare November 23, 2024 13:07
@aepfli aepfli changed the title [draft] sync pr with gherkin and testcontainers feat(flagd sync): add sync with proper e2e tests Nov 23, 2024
@aepfli aepfli changed the title feat(flagd sync): add sync with proper e2e tests feat(flagd sync): add sync with test containers tests Nov 23, 2024
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 9 times, most recently from ca544a4 to c68da7b Compare November 24, 2024 09:32
@aepfli
Copy link
Member Author

aepfli commented Nov 24, 2024

no more e2e tests are skipped 🎉

@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 3 times, most recently from cae988c to 87c50a4 Compare November 25, 2024 16:56
@aepfli aepfli marked this pull request as ready for review November 25, 2024 18:19
@aepfli aepfli requested a review from a team as a code owner November 25, 2024 18:19
@toddbaert
Copy link
Member

no more e2e tests are skipped 🎉

LEEEETSS GOOOOO!

@toddbaert
Copy link
Member

The only issue I found is that the enum for the resolver should be rpc | in-process instead of grpc | in-process, I pushed an update for this (code, docs, and tests).

@toddbaert toddbaert changed the title feat(flagd sync): add sync with test containers tests feat!: correct configuration params, stream reconnects, add tests Nov 25, 2024
@toddbaert toddbaert self-requested a review November 25, 2024 19:18
@aepfli
Copy link
Member Author

aepfli commented Dec 30, 2024

I merged all the previous work, and updated the implementation to match our latest findings regarding grpc. - there is room for improvements, eg. removing duplication between rpc and in-process for grpc connection etc. but i do think, this is something we can do in another step.

should i open a new pull request, or will we continue from here?

@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 5 times, most recently from 8945ff2 to 77b9eb8 Compare December 30, 2024 19:06
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch from 77b9eb8 to 75a2659 Compare February 4, 2025 17:31
@aepfli aepfli marked this pull request as ready for review February 6, 2025 16:32
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 3 times, most recently from 3a28e78 to 622208b Compare February 6, 2025 16:43
@aepfli aepfli changed the title feat!: correct configuration params, stream reconnects, add tests feat!(flagd): Add in-process evaluator Feb 6, 2025
@aepfli aepfli changed the title feat!(flagd): Add in-process evaluator feat(flagd): Add in-process evaluator Feb 6, 2025
@toddbaert toddbaert self-requested a review February 6, 2025 18:05
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one minor comment about the log level but don't want to block this.

@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 2 times, most recently from d00cf69 to 78c8fd5 Compare February 17, 2025 19:13
Co-authored-by: Cole Bailey <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch 2 times, most recently from b8d3886 to 1a81305 Compare February 17, 2025 19:17
Co-authored-by: Michael Beemer <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli force-pushed the feat/grpc-sync-addition branch from 1a81305 to 3ca43a4 Compare February 17, 2025 19:17
@aepfli
Copy link
Member Author

aepfli commented Feb 17, 2025

.. updated test-harness to also check for selector

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good 🍻

@beeme1mr beeme1mr merged commit 01285e7 into open-feature:main Feb 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants