fixup! Add evaluation details to finally hook stage #403

Signed-off-by: christian.lutnik <[email protected]>
open-feature · Jan 28, 2025 · 07b512e · 07b512e
1 parent 6f71842
commit 07b512e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/openfeature/client.py b/openfeature/client.py
@@ -393,6 +393,15 @@ def evaluate_flag_details(  # noqa: PLR0915
             return flag_evaluation
 
         finally:
+            if flag_evaluation is None: # should never happen, but keeps the linter happy
+                flag_evaluation = FlagEvaluationDetails(
+                    flag_key=flag_key,
+                    value=default_value,
+                    reason=Reason.ERROR,
+                    error_code=ErrorCode.GENERAL,
+                    error_message="Unknown error",
+                )
+
             after_all_hooks(
                 flag_type,
                 hook_context,

diff --git a/tests/features/steps/hooks_steps.py b/tests/features/steps/hooks_steps.py
@@ -55,6 +55,7 @@ def convert_value_from_flag_type(value, flag_type):
         return float(value)
     return value
 
+
 @then('"{hook_names}" hooks should have evaluation details')
 def step_impl_should_have_eval_details(context, hook_names):
     for hook_name in hook_names.split(", "):