Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update test harness (copy test files) #1467 #416

Merged

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Jan 21, 2025

This PR

Addendum to #415. Removes the test-harness submodule and temporarily copies the gherkin test files to the tests folder while the tests run.

Related Issues

Fixes #1467 (open-feature/flagd#1467)

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (b69e81a) to head (e207e4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          31       31           
  Lines        1387     1387           
=======================================
  Hits         1353     1353           
  Misses         34       34           
Flag Coverage Δ
unittests 97.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🍻

@gruebel gruebel merged commit 192f7c4 into open-feature:main Jan 23, 2025
15 checks passed
@chrfwow chrfwow deleted the Update-test-harness-(copy-files)-#1467 branch January 24, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants