-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OTel utility function #451
Conversation
Signed-off-by: gruebel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 97.72% 97.85% +0.12%
==========================================
Files 32 37 +5
Lines 1629 1723 +94
==========================================
+ Hits 1592 1686 +94
Misses 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks like the OTel Python sdk only supports attributes in both span and log events. @dyladan can we include value as an attribute? |
I agree All language implementations in OTel are experimental so I would refer to spec before referring to any language terms used. |
I've updated the JS implementation to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks! Good catch on the data vs body. I was just looking at the JS implementation but body is a better choice.
This PR
body
and notdata
, which seems to fit better to OTelRelated Issues
Fixes #448