Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add appendix D (observability) #287

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

toddbaert
Copy link
Member

  • adds small appendix section to spec that defines how particular SDK fields are mapped to the recently merge OTel semantics
  • this allows providers and hooks to export OTel data consistently for easy interop
  • adds a couple supporting glossary liks

@toddbaert toddbaert force-pushed the feat/appendix-d-observabilty branch from 8dd27f0 to fcbbf2a Compare December 16, 2024 19:20
specification/appendix-d-observability.md Outdated Show resolved Hide resolved
specification/appendix-d-observability.md Outdated Show resolved Hide resolved
specification/appendix-d-observability.md Outdated Show resolved Hide resolved
@toddbaert toddbaert force-pushed the feat/appendix-d-observabilty branch from fcbbf2a to 2d44c6d Compare December 16, 2024 19:43
@toddbaert
Copy link
Member Author

I've marked as draft for now since theres some ongoing conversations in OTel about how to represent certain types of event data: open-telemetry/semantic-conventions#1651 (comment)

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we might consider the PR I mentioned regarding the value_type, but I think we could also start with the value as any type and add the type hint from the PR later as it does not change the any type.

specification/appendix-d-observability.md Outdated Show resolved Hide resolved
specification/appendix-d-observability.md Outdated Show resolved Hide resolved
@toddbaert toddbaert requested a review from guidobrei January 13, 2025 19:01
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert force-pushed the feat/appendix-d-observabilty branch from e3ff639 to d71366d Compare January 13, 2025 19:06
@toddbaert toddbaert marked this pull request as ready for review January 13, 2025 19:06
@toddbaert toddbaert merged commit 6c673d7 into main Jan 15, 2025
7 checks passed
@toddbaert toddbaert deleted the feat/appendix-d-observabilty branch January 15, 2025 19:14
@toddbaert
Copy link
Member Author

Merged with just 3 approvals since we have a diverse set and this is just an appendix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants