Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: lower min required macOS version #52

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Dec 12, 2024

This PR

  • Lowers the required macOS version to 11.

Related Issues

Nope.

Notes

SDK doesn't use any API available only in macOS 12.
Also, the current min required version for iOS is 14, released in the same year as macOS 11 (2020).
And we are planning to use open-feature, but our app targets are too low 😅.

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @nicklasl do you have any concerns?

Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this MacOs version was decided but if it builds I don't have anything against this. 👍
I want to highlight however that me/we haven't tested this thoroughly on MacOs so this'll be a first :)

@nicklasl nicklasl merged commit 901d1ea into open-feature:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants