Merge pull request #601 from open-formulieren/fix/hash-base-routing-p…

…roblem ⚗️ Attempt hot-fix for hash based routing
open-formulieren · Dec 5, 2023 · 4576485 · 4576485
2 parents 9b50efa + 406e53a
commit 4576485
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/sdk.js b/src/sdk.js
@@ -95,12 +95,17 @@ class OpenForm {
     CSPNonce.setValue(CSPNonceValue);
     initialiseSentry(sentryDSN, sentryEnv);
 
-    // ensure that the basename has no trailing slash (for react router)
-    let pathname = basePath || window.location.pathname;
-    if (pathname.endsWith('/')) {
-      pathname = pathname.slice(0, pathname.length - 1);
+    if (useHashRouting) {
+      this.basePath = '';
+    } else {
+      // ensure that the basename has no trailing slash (for react router)
+      let pathname = basePath || window.location.pathname;
+      if (pathname.endsWith('/')) {
+        pathname = pathname.slice(0, pathname.length - 1);
+      }
+      this.basePath = pathname;
     }
-    this.basePath = pathname;
+
     this.calculateClientBaseUrl();
   }
 

diff --git a/src/sdk.spec.js b/src/sdk.spec.js
@@ -136,6 +136,6 @@ describe('OpenForm', () => {
       useHashRouting: true,
     });
 
-    expect(form.clientBaseUrl).toEqual('http://localhost/some-server-side/path#/some-subpath');
+    expect(form.clientBaseUrl).toEqual('http://localhost/some-server-side/path#/');
   });
 });