[OF#3671] Fix max date validation when current included #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 72.71% 73.72% +1.01%
==========================================
Files 214 214
Lines 4343 4343
Branches 1162 1162
==========================================
+ Hits 3158 3202 +44
+ Misses 1146 1102 -44
Partials 39 39 ☔ View full report in Codecov by Sentry. |
|
Tried to add a story-test for max date but same problem as for the min date. Can't find the way to make this pass automatically (it does show the error when we enter manually a wrong date). |
sergei-maertens
approved these changes
Dec 19, 2023
sergei-maertens
added
the
needs-backport
sergei-maertens
deleted the
of-3671/fix-maxdate-validation-when-current-included
branch
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 19, 2023
…rent included Backport-of: #616
|
Backports: 67678ae The validator code is not present in stable/1.5.x or older. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#3671