✨ [open-formulieren/open-forms#5033] User friendly error in case of 503 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 742 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 83.41% 83.62% +0.20%
==========================================
Files 240 241 +1
Lines 4752 4757 +5
Branches 1275 1268 -7
==========================================
+ Hits 3964 3978 +14
+ Misses 754 745 -9
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/5033-service-unavailable-error-message
branch
from
bd62356 to
c0ca478
Compare
stevenbal
commented
Jan 24, 2025
stevenbal
force-pushed
the
feature/5033-service-unavailable-error-message
branch
from
c0ca478 to
7476012
Compare
sergei-maertens
force-pushed
the
feature/5033-service-unavailable-error-message
branch
from
7476012 to
8dac57e
Compare
Not sure why exactly this is or isn't working properly with the built in decorator, but I suspect it has something to do with the error boundary of react router itself/the decorator and the error state not being reset properly when the story remounts. The workaround just creates a new memory router instance on every render of the story, discarding any router state between every story render which seems to solve the problem.
sergei-maertens
force-pushed
the
feature/5033-service-unavailable-error-message
branch
from
8dac57e to
0217758
Compare
sergei-maertens
approved these changes
Jan 28, 2025
sergei-maertens
deleted the
feature/5033-service-unavailable-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#5033