Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressNL component validation triggers on page load #785

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

robinmolen
Copy link
Contributor

Partly closes: open-formulieren/open-forms#4699

This is regarding one of the issues described in the OF#4699 ticket:

Sometimes the component validation triggers right after loading. The best way i can trigger this, is by making the component required and opening the frontend in incognito

The problem that caused this issues, was the default value of the addressNL component. This didn't conform to the expected value, which triggered a validation even before the user touched the form.

By setting the default value to an empty address this initial validation doesn't trigger

Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will increase total bundle size by 36 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.75MB 18 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 18 bytes (0.0%) ⬆️

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (49bd7cb) to head (61f1a7f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   83.32%   83.81%   +0.48%     
==========================================
  Files         239      239              
  Lines        4750     4750              
  Branches     1268     1275       +7     
==========================================
+ Hits         3958     3981      +23     
+ Misses        757      734      -23     
  Partials       35       35              
Flag Coverage Δ
storybook 76.31% <100.00%> (+0.54%) ⬆️
vitest 62.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 45f6c4e into main Jan 28, 2025
17 checks passed
@sergei-maertens sergei-maertens deleted the bug/4699-addressnl-validation branch January 28, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressNL validation on city & postcode issues
3 participants