Project itz fixes v2 (Klaas) to master #1379
Conversation
Changes of master were not correctly merged
Not used
Not really a clean implementation at this point.
Derived Habs to be able to easily check the model after translation
Changed the default to handle floors and ceilings as airtight
When an opening is horizontal, no different flows are expected due to the lack of stack effect, thus simplifying to less compartments is logical. Can this be 1?
commit 121cb9c Merge: 06aa135 a681abf Author: kldjonge <[email protected]> Date: Mon Aug 29 09:00:13 2022 +0200 Merge branch 'open-ideas:master' into master commit a681abf Author: Filip Jorissen <[email protected]> Date: Sat Aug 27 16:04:04 2022 +0200 default value for epsSw_shading in IDEAS//Buildings/Components/Shading/Interfaces/PartialShading.mo
…oject_itz_fixes_v2
… m_flow for unit testing.
This caused errors irrelevant to the model example
Model intended to show flow difference for seemingly similar models for large horizontal openings. Model adapted to highlight differences more. Documentation added.
This is cleaner as part of the multizone package
.mos files, revision notes and finished two examples
…ondition' warning while unit testing
…arning while unit testing
…to avoid unspecified initial condition warning
|
@kldjonge I had to modify the initialization of This led to slightly different reference results (below is a comparison between your initial model and my updated model). Could you verify whether this is still OK? Furthermore, I also get a similar warning for |
To be consistent with airflowboxmodel
|
Still okay! Results make sense given that the different initialisation dynamics. As previous I can not reproduce the issue in Dymola 2024x , but I now avoided the use of 'DynamicsFreeInitial'. I will make a new pull-request from my fork to project_itz_fixes_v2. |
Project itz fixes v2 kdj
…id initial condition error.
|
There was still an issue with If this is OK for both of you, I'll do a final review (mainly focussing on documentation and revision notes), and then we can merge this PR. A next and final step is then to merge these changes to the actual master branch. |
@kldjonge I merged your changes into the project_itz_fixes_v2 branch of the open-ideas repo (via PR #1376). I'll use this branch to fix typos and update the reference results. If you want to change something, please pull the latest changes of the project_itz_fixes_v2 to your local branch and later create a PR to merge your changes into this branch.
If everything appears to be fine, we can merge in the stack_effect_project_itz_master branch, after which we can merge to the master branch.
@Mathadon FYI