Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add digraj-pelia.md #3421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digraj-pelia
Copy link

@digraj-pelia digraj-pelia commented Oct 12, 2024

Important: Do not tick a checkbox if you haven’t performed its action.

Before Creating the Pull Request

  • Verify the changes are on a new branch other than master – it should say "compare: branch-name".
  • Start the pull request title with lowercase letters, e.g., add githubusername.md.
  • Add issue number to the end of the pull request title when applicable, e.g., update mi-faq.md (fixes #3264).

After Creating the Pull Request

  • Go to "Commits" tab, make sure the commit username is clickable and linked to your GitHub account correctly.
  • Review the "Files changed" tab to ensure there are no unnecessary files or changes included in the pull request.
  • Verify that the raw.githack preview link is included in the description.
    • Preview the MDwiki rendered changes using the raw.githack link. Ensure it displays as expected without any errors.
  • Drop a link to this pull request in our discord channel.

Description, Screenshots and/or Screencast

fixes #

Raw.Githack Preview Link

@xyb994
Copy link
Member

xyb994 commented Oct 14, 2024

Hello @digraj-pelia

  • Please don't forget to include the raw.githack link in the pull request description, you may still edit it with the 3 dot menu on the upper right of the description
  • Please drop the links and comment you made in our discord channel so we can check them out timely

Copy link
Member

@xyb994 xyb994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. External links are linked to John Doe, is that intentional?

@dogi dogi changed the title Create digraj-pelia.md create digraj-pelia.md Oct 14, 2024
@dogi dogi changed the title create digraj-pelia.md add digraj-pelia.md Oct 14, 2024
@xyb994 xyb994 added vi first steps - software engineering virtual intern stale labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale vi first steps - software engineering virtual intern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants