Skip to content

Commit

Permalink
chore(ui): bump quicktype to resolve vulnerabilities (#17979)
Browse files Browse the repository at this point in the history
* chore(ui): bump quicktype to resolve vulnerabilities

* fix test

* lower the version to avoid build issue

* revert service_account type changes

* added node-gyp as global package
  • Loading branch information
chirag-madlani authored Sep 25, 2024
1 parent 6541704 commit 65babfd
Show file tree
Hide file tree
Showing 6 changed files with 431 additions and 1,243 deletions.
3 changes: 3 additions & 0 deletions openmetadata-ui/src/main/resources/ui/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
},
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
}
2 changes: 1 addition & 1 deletion openmetadata-ui/src/main/resources/ui/json2ts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ getTypes(){
for file_with_dir in $(find $tmp_dir -name "*.json" | sed -e "s/${escaped_tmp_dir}//g")
do
joblist=$(jobs | wc -l)
while [ ${joblist} -ge 10 ]
while [ ${joblist} -ge 30 ]
do
sleep 1
joblist=$(jobs | wc -l)
Expand Down
4 changes: 2 additions & 2 deletions openmetadata-ui/src/main/resources/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"scripts": {
"start": "NODE_ENV=development BABEL_ENV=development webpack serve --config ./webpack.config.dev.js --env development",
"build": "NODE_ENV=production BABEL_ENV=production webpack --config ./webpack.config.prod.js --env production",
"preinstall": "cd ../../../../.. && yarn global add node-gyp && yarn install --frozen-lockfile",
"preinstall": "cd ../../../../.. && yarn install --frozen-lockfile",
"postinstall": "yarn run build-check",
"pre-commit": "lint-staged --concurrent false",
"test": "jest --passWithNoTests --maxWorkers=3 --silent",
Expand Down Expand Up @@ -253,4 +253,4 @@
"path-to-regexp": "1.9.0",
"terser-webpack-plugin": "5.1.1"
}
}
}
4 changes: 0 additions & 4 deletions openmetadata-ui/src/main/resources/ui/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ module.exports = {

// Input configuration
entry: ['@babel/polyfill', path.join(__dirname, 'src/index.tsx')],

cache: {
type: 'filesystem', // Enable caching on filesystem
},

// Output configuration
output: {
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@
"url": "https://github.com/open-metadata/OpenMetadata.git"
},
"devDependencies": {
"quicktype": "^17.0.6",
"node-gyp": "^10.0.1"
"quicktype": "20.0.27"
},
"scripts": {
"preinstall": "yarn global add node-gyp",
"preinstall": "yarn global add node-gyp@10.0.1",
"test": "echo \"Error: no test specified\" && exit 1"
}
}
Loading

0 comments on commit 65babfd

Please sign in to comment.