Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#10584: Add Data Model as an entity #10636

Merged
merged 18 commits into from
Mar 28, 2023
Merged

Fix#10584: Add Data Model as an entity #10636

merged 18 commits into from
Mar 28, 2023

Conversation

nahuelverdugo
Copy link
Contributor

Part of #10584

Describe your changes :

Add models and endpoints for Data Model as an entity.

Pending:

  • Example data
  • Improve testing
  • Add/Remove data model to a dashboard

Type of change :

  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Backend: @open-metadata/backend

@nahuelverdugo nahuelverdugo requested a review from a team as a code owner March 16, 2023 20:43
@nahuelverdugo nahuelverdugo mentioned this pull request Mar 16, 2023
Closed
10 tasks
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Mar 16, 2023
@cypress
Copy link

cypress bot commented Mar 16, 2023 •
edited
Loading

Passing run #18554 ↗︎

0 242 2 0 Flakiness 0

Details:

Add missing resource and event sub descriptors
Project: openmetadata Commit: d450c76ad7
Status: Passed Duration: 04:05 💡
Started: Mar 28, 2023 1:35 PM Ended: Mar 28, 2023 2:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nahuelverdugo nahuelverdugo requested a review from a team as a code owner March 17, 2023 12:55
@Daandamhuis
Copy link

@nahuelverdugo: Could this also be implemented for Power BI Data Models?

@nahuelverdugo
Copy link
Contributor Author

Hi @Daandamhuis, this PR will enable the ingestion of data models on the OM server side. We plan to ingest Looker and Tableau data models for the 1.0 release. If you have more info on extracting the data models from PowerBI, please fill in a feature request issue here. It would be helpful for us. Thank you :)

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@Daandamhuis
Copy link

Done :)

#10689

mohityadav766
mohityadav766 previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nahuelverdugo nahuelverdugo temporarily deployed to test March 28, 2023 13:12 — with GitHub Actions Inactive
@nahuelverdugo nahuelverdugo temporarily deployed to test March 28, 2023 13:12 — with GitHub Actions Inactive
@nahuelverdugo nahuelverdugo enabled auto-merge (squash) March 28, 2023 13:15
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@nahuelverdugo nahuelverdugo merged commit bea38d7 into open-metadata:main Mar 28, 2023
@nahuelverdugo nahuelverdugo temporarily deployed to publish March 28, 2023 15:07 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[openmetadata-service] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug D 30 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 11 Security Hotspots
Code Smell A 520 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daandamhuis Daandamhuis Daandamhuis left review comments

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@sureshms sureshms Awaiting requested review from sureshms

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nahuelverdugo @Daandamhuis @sureshms @harshach @mohityadav766