Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#10584: Tableau E2E and docs #11054

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Fix#10584: Tableau E2E and docs #11054

merged 6 commits into from
Apr 14, 2023

Conversation

nahuelverdugo
Copy link
Contributor

Describe your changes:

Add the E2E test as part of #10584 and documentation for includeDataModels and dataModelFilterPattern.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 13, 2023
@nahuelverdugo nahuelverdugo changed the title Fix#10584: Tableau E2E Fix#10584: Tableau E2E and docs Apr 13, 2023
akash-jain-10
akash-jain-10 previously approved these changes Apr 14, 2023
View reviewed changes
@cypress
Copy link

cypress bot commented Apr 14, 2023 •
edited
Loading

1 failed tests on run #19783 ↗︎

1 214 29 0 Flakiness 0

Details:

type fix
Project: openmetadata Commit: e4a1e53e7a
Status: Failed Duration: 22:48 💡
Started: Apr 14, 2023 9:58 AM Ended: Apr 14, 2023 10:21 AM
Failed  cypress/e2e/Pages/Glossary.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Glossary page should work properly > Remove Glossary term from entity should work properly Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

OnkarVO7
OnkarVO7 previously approved these changes Apr 14, 2023
View reviewed changes
@OnkarVO7 @ayush-shah
type fix
e4a1e53 
Co-authored-by: Ayush Shah <[email protected]>
@sonarqubecloud
Copy link

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@OnkarVO7 OnkarVO7 requested a review from akash-jain-10 April 14, 2023 10:02
@ayush-shah ayush-shah enabled auto-merge (squash) April 14, 2023 13:57
@ayush-shah ayush-shah disabled auto-merge April 14, 2023 13:58
@ayush-shah ayush-shah merged commit ea70580 into open-metadata:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

@ayush-shah ayush-shah ayush-shah approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10 akash-jain-10 is a code owner

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nahuelverdugo @akash-jain-10 @OnkarVO7 @ayush-shah