Protect against LTO optimizer #20
Conversation
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 2f8e2ba: Protect against LTO optimizer
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
hppritcha
force-pushed
the
upstream_pr1997
branch
from
2f8e2ba
to
c2c7c68
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: c2c7c68: Protect against LTO optimizer
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
1 similar comment
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: c2c7c68: Protect against LTO optimizer
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
We currently do not support the LTO optimizer as it is incompatible with our plugin component architecture. So detect it has been specified in configure and error out with an explanation. Includes suggestions from @jsquyres Signed-off-by: Ralph Castain <[email protected]>
hppritcha
force-pushed
the
upstream_pr1997
branch
from
c2c7c68
to
40fafc2
Compare
There was a problem hiding this comment.
Is the bot complaining that we have a cherry-picked message that refers to a commit in the upstream PRTE repo? Should we have a message in the commit - or perhaps change the cherry-pick message in there a little so that it's clear where this commit comes from (rather than implying that it comes from another commit in this same repo)?
|
Yes the bot is complaining about the cherry-picked commit not being in this repo. Do you know if there's a way to customize the string generated by git when using this "-x" option? google isn't helping... |
I do not think there is; you might just need to hand-edit it. |
We currently do not support the LTO optimizer
as it is incompatible with our plugin component
architecture. So detect it has been specified
in configure and error out with an explanation.
Includes suggestions from @jsquyres
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit dd7706c)