Use the PMIx functions to check params #21
Conversation
Break the multi-loop thru loading of param files that caused us to overwrite values. Defer to the PMIx pmdl components for obtaining envars and for checking MCA param overlaps across projects. Signed-off-by: Ralph Castain <[email protected]>
| @@ -2062,15 +1837,15 @@ static int detect_proxy(char *personalities) | |||
| /* this is a list of personalities we need to check - | |||
| * if it contains "ompi", then we are available */ | |||
| if (NULL != strstr(personalities, "ompi")) { | |||
| return translate_params(); | |||
| return 100; | |||
There was a problem hiding this comment.
Why a hardocded value? Is this a priority value?
There was a problem hiding this comment.
I'm guessing since these are ported over commits, you just leave things unchanged from how they are in the main prrte repo.
There was a problem hiding this comment.
Why a hardocded value? Is this a priority value?
Yes, it is - the max value means "pick me!"
|
Please note that you also require a newer version of PMIx that includes openpmix@a68d647 so it correctly parses the params. I have not made that a configure-level requirement because it is effectively a bug fix - you can operate without it, but may encounter an error depending on usage. |
|
I'm not sure the commit you're referencing is the right one. Which Openpmix is the one needed? |
|
No, that is the correct reference. You just need a PMIx hash at that point or beyond. Not in an official release yet. |
that's not a openpmix commit but a prrte one |
|
Ah crud - sorry for the confusion! openpmix/openpmix@2ef7524 |
Break the multi-loop thru loading of param files
that caused us to overwrite values. Defer to the
PMIx pmdl components for obtaining envars and for
checking MCA param overlaps across projects.