Restore parsing of OMPI param files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't perfect and it does raise precedence concerns, but let the OMPI schizo component parse the OMPI param files. Use the PMIx pmdl functions to check for relevant params to convert to PRRTE and PMIx. Restore the overlap detection for when params are set for OMPI frameworks that have a corrolary to frameworks in PRRTE and PMIx. This still raises precedence questions. For now, what this will do is have values in the OMPI param files give way to corresponding values specified in PRRTE and PMIx param files. In other words, values in PMIx and PRRTE param files are written into the environment, not overwriting any previously existing envar. OMPI param files are then read, and any params that correspond to PRRTE and PMIx params are written into the environment - without overwriting any that already exist. So if you have a param specified in a PRRTE param file, and you also specify it in the OMPI param file, the PRRTE param file value will "win". User beware - someone is bound to be very unhappy. Signed-off-by: Ralph Castain <[email protected]> (from upstream commit fcbefcc)
janjust
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't perfect and it does raise precedence
concerns, but let the OMPI schizo component
parse the OMPI param files. Use the PMIx
pmdl functions to check for relevant params
to convert to PRRTE and PMIx. Restore the
overlap detection for when params are set
for OMPI frameworks that have a corrolary
to frameworks in PRRTE and PMIx.
This still raises precedence questions. For
now, what this will do is have values in the
OMPI param files give way to corresponding
values specified in PRRTE and PMIx param
files. In other words, values in PMIx and
PRRTE param files are written into the
environment, not overwriting any previously
existing envar. OMPI param files are then
read, and any params that correspond to
PRRTE and PMIx params are written into
the environment - without overwriting
any that already exist.
So if you have a param specified in a
PRRTE param file, and you also specify it
in the OMPI param file, the PRRTE param file
value will "win".
User beware - someone is bound to be very
unhappy.
Signed-off-by: Ralph Castain [email protected]
(from upstream commit fcbefcc)