Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code generator for hybrid algorithms #608

Closed
baentsch opened this issue Jan 2, 2025 · 2 comments · Fixed by #606
Closed

Fix code generator for hybrid algorithms #608

baentsch opened this issue Jan 2, 2025 · 2 comments · Fixed by #606

Comments

@baentsch
Copy link
Member

baentsch commented Jan 2, 2025

The code generator seems to be brittle in that it creates ECX logic if the classic algorithm does not start with the letter "p".
@baentsch baentsch mentioned this issue Jan 2, 2025
Merged
@SWilson4
Copy link
Member

SWilson4 commented Jan 2, 2025

I think @bhess and @praveksharma were the last to work on this feature, so looping them in.

@baentsch
Copy link
Member Author

baentsch commented Jan 2, 2025

Not really necessary any more: Already fixed in update to #606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change code point and name for mlkem1024 hybrid open-quantum-safe/oqs-provider
2 participants
@SWilson4 @baentsch