Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change code point and name for mlkem1024 hybrid #606

Merged
merged 2 commits into from
Jan 3, 2025
Merged

change code point and name for mlkem1024 hybrid #606

merged 2 commits into from
Jan 3, 2025

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Jan 1, 2025 •
edited
Loading

@baentsch baentsch requested a review from a team January 1, 2025 06:52
@baentsch
Copy link
Member Author

baentsch commented Jan 1, 2025

Also tagging/asking for review by @bencemali

SWilson4
SWilson4 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one cosmetic suggestion.

oqs-template/oqs-kem-info.md Outdated Show resolved Hide resolved
@baentsch
make ECP naming more robust
5625ec1 
Signed-off-by: Michael Baentsch <[email protected]>
@baentsch baentsch mentioned this pull request Jan 2, 2025
Closed
@baentsch baentsch merged commit 4638c05 into main Jan 3, 2025
56 checks passed
@baentsch baentsch deleted the mb-mlkem1024hybrid branch January 3, 2025 10:01
@bencemali
Copy link
Contributor

@baentsch retrospectively it seems perfectly fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWilson4 SWilson4 SWilson4 approved these changes

@bhess bhess Awaiting requested review from bhess bhess is a code owner

@feventura feventura Awaiting requested review from feventura feventura is a code owner

@alexrow alexrow Awaiting requested review from alexrow alexrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code generator for hybrid algorithms
3 participants
@baentsch @bencemali @SWilson4