Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MAYO #413

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Add MAYO #413

merged 7 commits into from
Jul 26, 2024

Conversation

bhess
Copy link
Member

@bhess bhess commented May 14, 2024

Tracker for MAYO integration in liboqs: open-quantum-safe/liboqs#1707

@cothan cothan mentioned this pull request Jun 12, 2024
Merged
2 tasks
Gangstablue777

This comment was marked as spam.

Sign in to view

@bhess
Add MAYO
a42e420 
Signed-off-by: Basil Hess <[email protected]>
@bhess bhess force-pushed the bhe-nibbling-mayo-tracker branch from cf69ef1 to aa5267a Compare July 10, 2024 07:28
@bhess
re-generate after rebase
6c33846 
Signed-off-by: Basil Hess <[email protected]>
@bhess bhess force-pushed the bhe-nibbling-mayo-tracker branch from aa5267a to 6c33846 Compare July 10, 2024 07:33
@bhess bhess mentioned this pull request Jul 11, 2024
Merged
10 tasks
@bhess bhess force-pushed the bhe-nibbling-mayo-tracker branch from 496aa86 to 24a1842 Compare July 12, 2024 18:06
@bhess
naming update
3002ff5 
Signed-off-by: Basil Hess <[email protected]>
@bhess bhess force-pushed the bhe-nibbling-mayo-tracker branch 2 times, most recently from bbca395 to 7011f7d Compare July 16, 2024 08:20
@bhess
Adding mayo5
79aa5af 
Signed-off-by: Basil Hess <[email protected]>
@bhess bhess force-pushed the bhe-nibbling-mayo-tracker branch from 7011f7d to 79aa5af Compare July 16, 2024 08:25
@bhess
Set CI to liboqs main
3b7b5d4 
Signed-off-by: Basil Hess <[email protected]>
@baentsch
Copy link
Member

CI for this PR queued for more than 20h:
grafik

This does not seem to be a transient GH problem as per https://www.githubstatus.com/, so what's going on here? Should we simply reduce MacOS CI/support or is this sth that can be resolved with proper funding? @ryjones ?

@bhess
exclude macos-11 runner
6c47f51 
Signed-off-by: Basil Hess <[email protected]>
@bhess
Copy link
Member Author

bhess commented Jul 18, 2024

CI for this PR queued for more than 20h: grafik

This does not seem to be a transient GH problem as per https://www.githubstatus.com/, so what's going on here? Should we simply reduce MacOS CI/support or is this sth that can be resolved with proper funding? @ryjones ?

I don't know if this is related to the CI not running, but MacOS 11 seems to be end of life: https://endoflife.date/macos, so I think it should be ok to drop the macos-11 runner (done now in this PR).

@bhess bhess marked this pull request as ready for review July 18, 2024 13:16
@bhess bhess requested a review from baentsch as a code owner July 18, 2024 13:16
@ryjones
Copy link

ryjones commented Jul 18, 2024

Yes, @bhess @baentsch , GitHub has dropped MacOS 11 support.

baentsch
baentsch approved these changes Jul 25, 2024
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
@bhess bhess merged commit 97bc088 into main Jul 26, 2024
2 checks passed
@bhess bhess deleted the bhe-nibbling-mayo-tracker branch July 26, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gangstablue777 Gangstablue777 Gangstablue777 left review comments

@baentsch baentsch baentsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhess @baentsch @ryjones @Gangstablue777