-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use median in calculating recall cost, forget cost and learn cost #109
Feat/use median in calculating recall cost, forget cost and learn cost #109
Conversation
Are zeros removed? As user1823 said, we should remove all values that are precisely equal to 0. |
Should these revlogs be removed in training? |
No, I meant that if review time=0 ms, it should be excluded from the median calculation. Though it might be a good idea to exclude them from everything. |
I don't think that we should filter them during training the parameters unless someone gives us a specific scenario where they cause a problem. |
Now zero values have been removed in calculating the cost. |
I can't verify the accuracy of the code but broadly it looks good to me. |
Wait a minute, I couldn't find anything that removes the reviews with time > 20 min. |
Yeah, those should be excluded. |
Thanks for reviews! |
No description provided.