Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve workload plotting.py #137

Merged
merged 1 commit into from
Sep 9, 2024
Merged

improve workload plotting.py #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions src/fsrs_optimizer/fsrs_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,8 @@ def workload_graph(default_params, sampling_size=30):

min_w2 = 0
min_w3 = 0
target2 = 2 * min_w
target3 = 3 * min_w
target2 = 1.5 * min_w
target3 = 2 * min_w

for i in range(len(workload) - 1):
if (workload[i] <= target2) and (workload[i + 1] >= target2):
Expand Down Expand Up @@ -518,7 +518,7 @@ def workload_graph(default_params, sampling_size=30):
elif max_w >= 3.5 * min_w:
lim = 3.5 * min_w
else:
lim = max_w
lim = 1.1 * max_w

ax.set_ylim(0, lim)
ax.set_ylabel("Workload (minutes of study per day)", fontsize=20)
Expand All @@ -533,34 +533,45 @@ def workload_graph(default_params, sampling_size=30):
color="black",
fontsize=12,
)
if max_w >= 1.8 * min_w:
ax.axhline(y=1.5 * min_w, color="black", alpha=0.75, ls="--")
ax.text(
0.701,
1.5 * min_w,
"minimum workload x1.5",
ha="left",
va="bottom",
color="black",
fontsize=12,
)
if max_w >= 2.3 * min_w:
ax.axhline(y=2 * min_w, color="black", alpha=0.75, ls="--")
ax.text(
0.701,
2 * min_w,
"min. workload x2",
"minimum workload x2",
ha="left",
va="bottom",
color="black",
fontsize=12,
)
if max_w >= 3.3 * min_w:
ax.axhline(y=3 * min_w, color="black", alpha=0.75, ls="--")
if max_w >= 2.8 * min_w:
ax.axhline(y=2.5 * min_w, color="black", alpha=0.75, ls="--")
ax.text(
0.701,
3 * min_w,
"min. workload x3",
2.5 * min_w,
"minimum workload x2.5",
ha="left",
va="bottom",
color="black",
fontsize=12,
)
if max_w >= 4.3 * min_w:
ax.axhline(y=4 * min_w, color="black", alpha=0.75, ls="--")
if max_w >= 3.3 * min_w:
ax.axhline(y=3 * min_w, color="black", alpha=0.75, ls="--")
ax.text(
0.701,
4 * min_w,
"min. workload x4",
3 * min_w,
"minimum workload x3",
ha="left",
va="bottom",
color="black",
Expand Down