-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the R_MAX of CMRR.rs #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think that DR above 0.96 doesn't make much sense because the returns are diminishing. In this image, see the drastic increase in slope above DR = 0.96. (There are occasional high slopes before DR = 0.96 too but after DR = 0.96, most of the values are too high.) |
The data is based on default parameters. |
Well, it is OK if you think that some people can have such a high value of MRR. But, I am not really convinced. Nonetheless, let's forget about this for now. We can always decrease the value if someone complains. |
We can change it slightly to 0.97 instead of 0.98 |
@L-M-Sherlock do you think we should revert this (or set R_MAX to 0.96 or 0.97)? It seems like the idea that previous values were underestimates was based on the wrong data |
This reverts commit 479c387.
open-spaced-repetition/fsrs4anki#686 (comment)
It appears that our previous estimates of optimal retention were underestimates. I think it makes sense to expand the range.
Note that here it says "workload", but it's not just workload, it's workload/knowledge