[receiver/otlpjsonfile] append token.Attributes to scoped attribute of the signal #36715
+92
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
requested review from
djaglowski,
atoulme and
a team
as code owners
khushijain21
changed the title
|
@khushijain21 please an entry to changelog. This is a user-facing bug fix. |
atoulme
reviewed
Dec 16, 2024
| component: otlpjsonfilereceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Parse token.attributes and append it to the log record |
There was a problem hiding this comment.
There was a problem hiding this comment.
I know :) Can you please make it more explicit for folks reading the changelog who might not know what that is?
|
Please resolve the conflict, fix the changelog message, and we'll be good to go. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme can you take look? |
atoulme
approved these changes
Jan 24, 2025
atoulme
added
the
ready to merge
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…f the signal (open-telemetry#36715) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description It loops through token.Attributes and appends it to the scoped attribute of the signal <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36641 <!--Describe what testing was performed and which tests were added.--> #### Testing Added UT <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It loops through token.Attributes and appends it to the scoped attribute of the signal
Link to tracking issue
Fixes #36641
Testing
Added UT
Documentation