Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/activedirectoryds] [docs] Update example in README #37424

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

iancoralogix
Copy link
Contributor

Description

Update example in README to reflect map instead of bool that is expected.

$ otelcol --version                                                                                                                          
otelcontribcol version 0.118.0-dev 

$ otelcol validate --config config.yaml
Error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following error(s):

error decoding 'receivers': error reading configuration for "active_directory_ds": decoding failed due to the following error(s):

'metrics.active_directory.ds.replication.network.io' expected a map, got 'bool'
2025/01/22 18:33:20 collector server run finished with error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following
 error(s):

error decoding 'receivers': error reading configuration for "active_directory_ds": decoding failed due to the following error(s):

'metrics.active_directory.ds.replication.network.io' expected a map, got 'bool'


Link to tracking issue

Fixes

Testing

Documentation

Updated example used in README for this receiver to not throw errors.

@iancoralogix iancoralogix requested a review from a team as a code owner January 22, 2025 23:34
Copy link

linux-foundation-easycla bot commented Jan 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @iancoralogix, please sign the CLA so we can review/merge the PR

@iancoralogix
Copy link
Contributor Author

@codeboten all signed, thank you!

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 24, 2025
@andrzej-stencel andrzej-stencel merged commit 0abff4c into open-telemetry:main Jan 24, 2025
154 of 155 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/activedirectoryds Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants