Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update core dependencies #37447

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Conversation

opentelemetrybot
Copy link
Contributor

This PR updates the opentelemetry-collector dependency to the latest release

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like more checks need addressing

@codeboten codeboten self-requested a review January 24, 2025 05:31
@mx-psi
Copy link
Member

mx-psi commented Jan 24, 2025

Filed #37471 to fix a few more tests

@evan-bradley
Copy link
Contributor

The promotion of exporter.UsePullingBasedExporterQueueBatcher from alpha to beta is causing some otelarrow exporter tests to break due to a change in how contexts are passed. I'm looking into why this is happening.

Fixes issues that arise from the recent promotion of
`exporter.UsePullingBasedExporterQueueBatcher` from alpha to beta.

Needed for
#37447.
@codeboten
Copy link
Contributor

the build-and-test / check-collector-module-version still seems unhappy

@mx-psi
Copy link
Member

mx-psi commented Jan 24, 2025

The promotion of exporter.UsePullingBasedExporterQueueBatcher from alpha to beta is causing some otelarrow exporter tests to break due to a change in how contexts are passed. I'm looking into why this is happening.

@bogdandrutu @sfc-gh-sili could you help with this?

Fixes some more issues with the OTel update
@evan-bradley
Copy link
Contributor

The promotion of exporter.UsePullingBasedExporterQueueBatcher from alpha to beta is causing some otelarrow exporter tests to break due to a change in how contexts are passed. I'm looking into why this is happening.

@bogdandrutu @sfc-gh-sili could you help with this?

Sorry, should have given an update. I think this should be taken care of with #37476. I believe it's because the feature gate enabled queuing that breaks context propagation.

Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor

I pushed a change run tidy to address some of the failing checks

@atoulme
Copy link
Contributor

atoulme commented Jan 24, 2025

You need to run make generate to regenerate tests. mdatagen has tweaks that will regenerate tests.

@codeboten
Copy link
Contributor

Note sure what to do about these failures:

=== FAIL: . TestConsumeMetricsAccessTokenPassthroughPriorityToContext/passthrough_access_token_and_not_included_in_md (re-run 1) (0.01s)
    exporter_test.go:698: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/signalfxexporter/exporter_test.go:698
        	Error:      	Not equal: 
        	            	expected: []string{"AccessTokenFromContext"}
        	            	actual  : []string{"AccessTokenFromClientHeaders"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,3 @@
        	            	 ([]string) (len=1) {
        	            	- (string) (len=22) "AccessTokenFromContext"
        	            	+ (string) (len=28) "AccessTokenFromClientHeaders"
        	            	 }
        	Test:       	TestConsumeMetricsAccessTokenPassthroughPriorityToContext/passthrough_access_token_and_not_included_in_md

@mx-psi
Copy link
Member

mx-psi commented Jan 24, 2025

Note sure what to do about these failures:

=== FAIL: . TestConsumeMetricsAccessTokenPassthroughPriorityToContext/passthrough_access_token_and_not_included_in_md (re-run 1) (0.01s)
    exporter_test.go:698: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/signalfxexporter/exporter_test.go:698
        	Error:      	Not equal: 
        	            	expected: []string{"AccessTokenFromContext"}
        	            	actual  : []string{"AccessTokenFromClientHeaders"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,3 @@
        	            	 ([]string) (len=1) {
        	            	- (string) (len=22) "AccessTokenFromContext"
        	            	+ (string) (len=28) "AccessTokenFromClientHeaders"
        	            	 }
        	Test:       	TestConsumeMetricsAccessTokenPassthroughPriorityToContext/passthrough_access_token_and_not_included_in_md

Sounds vaguely related to #37447 (comment) ?

@evan-bradley
Copy link
Contributor

evan-bradley commented Jan 24, 2025

I've got a fix for those. Not sure how to push directly to this PR, I'll open up a PR pointed at the branch.

Edit: I guess you just open up a PR and merge it right away, should be good to go now.

@codeboten
Copy link
Contributor

i'll get the versions syncd

@evan-bradley
Copy link
Contributor

evan-bradley commented Jan 24, 2025

I couldn't merge main into this PR, so I replayed the change to fix the check-codeowners check.

Edit: That apparently didn't fix all the issues. It's not a required check anyway, maybe we just allow it to fail.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten merged commit e8c493a into main Jan 24, 2025
162 of 163 checks passed
@codeboten codeboten deleted the opentelemetrybot/update-otel-1737650898 branch January 24, 2025 17:22
@github-actions github-actions bot added this to the next release milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants