Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/github] add workflow run event trace handling #37578
base: main
Are you sure you want to change the base?
[receiver/github] add workflow run event trace handling #37578
Changes from all commits
325a0d5
4cacce0
7302643
d164f09
c1849cf
b4a4a8f
f6edd9d
f4b4f8b
95a160f
a47d810
8b2f03b
1aedf0c
0fb1286
0184a71
bedfbaf
982ca2f
b3ec694
a8b9b58
9980832
c455735
5727ddc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the configuration format is changing, shouldn't this be considered a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the functionality of this portion of the receiver has only been serving a health check endpoint and is marked "development." The previous config value wouldn't have worked anyway since this is not of the health check endpoint, and only for the events portion. I guess I'm saying, there was nothing to break, since there wasn't anything that "worked." But happy to mark it if necessary in the change log for sanity.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.