Revert "[chore] Replace usage of metadatatest.SetupTelemetry with new componentest" #37626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compone…" This reverts commit 0af2e2d.
github-actions
bot
added
exporter/prometheusremotewrite
processor/groupbyattrs
github-actions
bot
requested review from
Aneurysm9,
ArthurSens,
dashpole,
mcardy,
rapphil and
rnishtala-sumo
|
I'm not sure it's related that PR. I've just made a change to the compliance test that I shouldn't have made. At least not yet |
|
@ArthurSens you're right probably, the prometheus-compliance-tests still failed in this PR |
|
I'm reverting the PR over there and merging again only once #36873 is ready |
|
Reverted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37613