[cmd/opampsupervisor] ensure OnConnectClosed is hooked up #37761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnConnectionClose was never hooked up to the server's OnConnectionClose, causing the restart of the agent to never be able to reconnect. Signed-off-by: Alex Boten <[email protected]>
codeboten
requested review from
evan-bradley,
atoulme,
tigrannajaryan and
a team
as code owners
TylerHelmuth
approved these changes
Feb 6, 2025
Signed-off-by: Alex Boten <[email protected]>
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…etry#37761) OnConnectionClose was never hooked up to the server's OnConnectionClose, causing the restart of the agent to never be able to reconnect. --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnConnectionClose was never hooked up to the server's OnConnectionClose, causing the restart of the agent to never be able to reconnect.