Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter] mark module as stable #10363

Closed
wants to merge 3 commits into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jun 7, 2024

Description

Move filter module to stable.

Link to tracking issue

Fixes #10349

This PR can be merged after #10362 is merged.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (72c23aa) to head (82150c5).
Report is 65 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10363   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         386      386           
  Lines       18402    18402           
=======================================
  Hits        16997    16997           
  Misses       1052     1052           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme marked this pull request as ready for review June 18, 2024 22:21
@atoulme atoulme requested review from a team and bogdandrutu June 18, 2024 22:21
@atoulme atoulme removed the on hold label Jun 20, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jun 26, 2024

#10349 (comment)
From @dmitryax

This is very new package. Should be considered experimental for now. I don't think it's ready for 1.0. I would suggest holding off on this one and focus on other modules for now

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Jul 11, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jul 12, 2024

Let's not do it yet. Closing.

@atoulme atoulme closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module go.opentelemetry.io/collector/filter
2 participants