Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix: pin markdown-link-check to v3.12.2 #11605

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[chore] fix: pin markdown-link-check to v3.12.2 #11605

merged 1 commit into from
Nov 5, 2024

Conversation

andrzej-stencel
Copy link
Member

To prevent it from using v3.13.x which is currently broken by tcort/markdown-link-check#368.

@andrzej-stencel
Pin markdown-link-check to v3.12.2
cbb51b7 
To prevent it from using v3.13.x which is currently broken by tcort/markdown-link-check#368.
@andrzej-stencel andrzej-stencel requested a review from a team as a code owner November 5, 2024 16:23
mx-psi
mx-psi approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we file an issue to manage updating this moving forward? We can probably do it with renovatebot

@andrzej-stencel andrzej-stencel mentioned this pull request Nov 5, 2024
Open
@andrzej-stencel
Copy link
Member Author

Could we file an issue to manage updating this moving forward? We can probably do it with renovatebot

Good point, created #11606.

@codeboten codeboten merged commit 3b7f68d into open-telemetry:main Nov 5, 2024
50 of 51 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 5, 2024
@andrzej-stencel andrzej-stencel deleted the pin-markdown-link-check branch November 5, 2024 16:46
@jackgopack4 jackgopack4 mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
Skip Contrib Tests
Projects
None yet
Milestone
v0.113.0
Development

Successfully merging this pull request may close these issues.
5 participants
@andrzej-stencel @codeboten @bogdandrutu @mx-psi @songy23