Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] rename confmap modules to ConfmapConverters and ConfmapProviders #11678

Merged

Conversation

jackgopack4
Copy link
Contributor

Description

change name in templates and cmd/builder to refer to Providers and Converters as ConfmapProviders and ConfmapConverters

Link to tracking issue

as requested here: #11653 (comment)

Testing

existing tests should cover this

Documentation

none, internal change and no new code/api

@jackgopack4 jackgopack4 requested a review from a team as a code owner November 14, 2024 18:17
@jackgopack4 jackgopack4 changed the title rename confmap modules to ConfmapConverters and ConfmapProviders [chore] rename confmap modules to ConfmapConverters and ConfmapProviders Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (3fe42eb) to head (252d8f7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11678   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         442      442           
  Lines       23746    23746           
=======================================
  Hits        21761    21761           
  Misses       1616     1616           
  Partials      369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 1d87709 into open-telemetry:main Nov 14, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants