-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component] Deprecate TelemetrySettings.MetricsLevel #12159
Merged
mx-psi
merged 6 commits into
open-telemetry:main
from
mx-psi:mx-psi/metricslevel-detailed
Jan 24, 2025
Merged
[component] Deprecate TelemetrySettings.MetricsLevel #12159
mx-psi
merged 6 commits into
open-telemetry:main
from
mx-psi:mx-psi/metricslevel-detailed
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12159 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 464 464
Lines 24763 24763
=======================================
Hits 22722 22722
Misses 1656 1656
Partials 385 385 ☔ View full report in Codecov by Sentry. |
mx-psi
force-pushed
the
mx-psi/metricslevel-detailed
branch
from
January 22, 2025 17:19
ef0a27f
to
b51e37e
Compare
mx-psi
added
the
release:blocker
The issue must be resolved before cutting the next release
label
Jan 22, 2025
bogdandrutu
reviewed
Jan 22, 2025
bogdandrutu
approved these changes
Jan 23, 2025
Merged
via the queue into
open-telemetry:main
with commit Jan 24, 2025
2447a81
52 of 53 checks passed
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
…12159) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> - Deprecates `component.TelemetrySettings.MetricsLevel` - Sets the value passed to components to always be `configtelemetry.LevelDetailed` #### Link to tracking issue Updates open-telemetry#11061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
component.TelemetrySettings.MetricsLevel
configtelemetry.LevelDetailed
Link to tracking issue
Updates #11061