Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Deprecate TelemetrySettings.MetricsLevel #12159

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 22, 2025

Description

  • Deprecates component.TelemetrySettings.MetricsLevel
  • Sets the value passed to components to always be configtelemetry.LevelDetailed

Link to tracking issue

Updates #11061

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (e8807bf) to head (349e6d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12159   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         464      464           
  Lines       24763    24763           
=======================================
  Hits        22722    22722           
  Misses       1656     1656           
  Partials      385      385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi force-pushed the mx-psi/metricslevel-detailed branch from ef0a27f to b51e37e Compare January 22, 2025 17:19
@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Jan 22, 2025
@mx-psi mx-psi marked this pull request as ready for review January 22, 2025 17:20
@mx-psi mx-psi requested a review from a team as a code owner January 22, 2025 17:20
@mx-psi mx-psi requested a review from atoulme January 22, 2025 17:20
service/service.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from bogdandrutu January 23, 2025 11:00
@mx-psi mx-psi enabled auto-merge January 24, 2025 11:50
@mx-psi mx-psi added this pull request to the merge queue Jan 24, 2025
Merged via the queue into open-telemetry:main with commit 2447a81 Jan 24, 2025
52 of 53 checks passed
@mx-psi mx-psi deleted the mx-psi/metricslevel-detailed branch January 24, 2025 12:24
sfc-gh-sili pushed a commit to sfc-gh-sili/opentelemetry-collector that referenced this pull request Feb 3, 2025
…12159)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

- Deprecates `component.TelemetrySettings.MetricsLevel`
- Sets the value passed to components to always be
`configtelemetry.LevelDetailed`

#### Link to tracking issue

Updates open-telemetry#11061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants