-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer arrays of name value pairs over objects #115
Prefer arrays of name value pairs over objects #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
See comments.
a4248d9
to
2849441
Compare
…y-configuration into prefer-name-value-pairs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, otherwise this looks ok to me
…y-configuration into prefer-name-value-pairs
Co-authored-by: Alex Boten <[email protected]>
…g/opentelemetry-configuration into prefer-name-value-pairs
@marcalff, @codeboten - I've resolved merge conflicts and incorporated feedback. Can you take another look? Thanks. |
Resolves #72.
May also resolve open-telemetry/opentelemetry-specification#2857.
This PR migrates
.resource.attributes
and*.otlp.headers
to be key-value pairs instead of objects, and adds a modeling rule to follow this pattern for similar situations in the future. To repeat the reasoning from the modeling rule:The more I think about it, the more I think this the way the way to go. Note that this is how environment variables are specified in kubernetes manifests, so it shouldn't be particularly foreign to users.
We should get this change in sooner than later to minimize the number of users we expose to churn.