Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved file_format documentation #137

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 1, 2024

Improved the documentation for file_format.

Point to the yaml schema definition, which helps when editing the configuration file.

Also, fixed typos ("nand" -> "and", "ot" -> "to").

@marcalff marcalff requested a review from a team as a code owner November 1, 2024 00:40
@marcalff marcalff changed the title Improved file_format documentation. Improved file_format documentation Nov 1, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcalff, it occurred to me as I was reading this that the file_format and the release version number differ.

We should fix this to be consistent.

@marcalff
Copy link
Member Author

marcalff commented Nov 4, 2024

Thanks @marcalff, it occurred to me as I was reading this that the file_format and the release version number differ.

We should fix this to be consistent.

I assume you mean file_format: 0.3 versus tag v0.3.0.

This relates to the discussion about:

where we need to define when major/minor/patch versions are incremented.

In my opinion, we need a way to make a new release that can contain:

  • more documentation
  • spelling fixes
  • more test cases
  • fixes in CI, makefiles, etc

that is, release everything except changes to the yaml schema itself, without forcing users to do a version bump in their own config.yaml.

If we reserve patch version for these changes, then for example, a new release of this repo, tagged v0.3.1, can contain more documentation (this very PR) compared to previous release v0.3.0, while users refer to file_format: 0.3.

So, the fact that a release uses MAJOR.MINOR.PATCH, while a config.yaml refers to a MAJOR.MINOR schema, looks ok to me: on the contrary, we need this discrepancy to deliver changes that do not affect the yaml schema.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If no objections, I can merge.

@codeboten codeboten merged commit e1f89ef into open-telemetry:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants