-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing attributes with AddEvent #60
Conversation
@@ -0,0 +1,27 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder about moving this from trace
to common
? We will need the same functionality for metrics labels and, I assume, also for logs at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
nostd::span<const int64_t>, | ||
nostd::span<const unsigned int>, | ||
nostd::span<const uint64_t>, | ||
nostd::span<const nostd::string_view>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also this discussion going on: open-telemetry/opentelemetry-specification#376.
I'm not sure how serious that is, but it seems the idea is getting traction and is actively discussed currently. Maybe @reiley knows how likely this is to come and whether we should consider it.
Builds on top of #59
Allows attributes to be passed without copying from convertible key-value containers.
Examples of how it can be used