Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING file #127

Merged
merged 11 commits into from
Aug 22, 2024
Merged

Add CONTRIBUTING file #127

merged 11 commits into from
Aug 22, 2024

Conversation

dmathieu
Copy link
Member

This adds a CONTRIBUTING file, so new contributors better know what to expect.
I based this on the otel-go contributing file, with some adjustements.
Everything is open for comments obviously.

@dmathieu dmathieu marked this pull request as ready for review August 21, 2024 08:50
@dmathieu dmathieu requested review from a team August 21, 2024 08:50
Copy link
Member

@christos68k christos68k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
dmathieu and others added 5 commits August 21, 2024 11:18
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling this! :)

@athre0z athre0z merged commit 4c526c9 into open-telemetry:main Aug 22, 2024
22 checks passed
@dmathieu dmathieu deleted the contributing branch August 22, 2024 11:59
florianl added a commit to florianl/opentelemetry-ebpf-profiler that referenced this pull request Aug 30, 2024
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
Co-authored-by: Joel Höner <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants