Various fixes to node/V8 #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
reviewed
Jan 30, 2025
interpreter/nodev8/v8.go
Outdated
| // that manually here. | ||
| vms.ScopeInfo.HeapObject = true | ||
| } | ||
| if d.version >= v8Ver(12, 5, 0) && !vms.DeoptimizationData.FixedArray && !vms.DeoptimizationData.TrustedFixedArray { |
There was a problem hiding this comment.
Can you also update the list of supported versions near the start of the file?
florianl
reviewed
Feb 4, 2025
christos68k
approved these changes
Feb 4, 2025
umanwizard
force-pushed
the
v8
branch
2 times, most recently
from
0820df7 to
7716075
Compare
florianl
reviewed
Feb 5, 2025
| @@ -414,9 +425,20 @@ type v8Data struct { | |||
| Flags uint16 `name:"flags__uint32_t"` | |||
| } | |||
|
|
|||
| DeoptimizationData struct { | |||
There was a problem hiding this comment.
Can you add a link to the origin of this struct? Similar to the other structs above?
Also please for SourcePositionTable and SharedFunctionInfoWrapper.
| @@ -1877,6 +1932,26 @@ func (d *v8Data) readIntrospectionData(ef *pfelf.File, syms libpf.SymbolFinder) | |||
| } | |||
|
|
|||
| // Add some defaults when needed | |||
| if d.version >= v8Ver(11, 9, 0) { | |||
| // the class hierarchy changed: HeapObject no longer | |||
| // derives from Object. This confuses gen-postmortem-metadata.py | |||
There was a problem hiding this comment.
Neat script - maybe we should name it more prominently somewhere to help people dig into this unwinder.
There was a problem hiding this comment.
We do mention it in the main comment at the top of the file: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/44a0c25/interpreter/nodev8/v8.go#L28-L33
as well as various other places throughout v8.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings us up to date with the latest origin/main of Node.