Skip to content

Commit

Permalink
Temporarily consider 429s as success in links check (#6210)
Browse files Browse the repository at this point in the history
This considers 429s as a success, until we can get lychee to cache
success requests even if there's a failure.
This should only be a temporary measure. But ignoring one status code
seems better than entirely disabling the check.

Related: #6183.
  • Loading branch information
dmathieu authored Oct 10, 2024
1 parent c13ee4b commit 60905d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/links-fail-fast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,5 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
fail: true
args: --max-concurrency 5 --cache --max-cache-age 1d .
# TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved
args: --max-concurrency 5 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 .
3 changes: 2 additions & 1 deletion .github/workflows/links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: --max-concurrency 1 --cache --max-cache-age 1d .
# TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved
args: --max-concurrency 1 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 .

- name: Create Issue From File
if: steps.lychee.outputs.exit_code != 0
Expand Down

0 comments on commit 60905d6

Please sign in to comment.