-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation/http/otelhttp): move client metrics creation into internal semconv package #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o internal semconv package
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
=====================================
Coverage 67.1% 67.2%
=====================================
Files 194 194
Lines 12709 12766 +57
=====================================
+ Hits 8533 8584 +51
- Misses 3901 3904 +3
- Partials 275 278 +3
|
It looks like the lint CI is failing. Please run |
dashpole
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Aug 15, 2024
This is now ready for review. |
dashpole
reviewed
Aug 16, 2024
@open-telemetry/go-approvers PTAL |
Overall, it looks good to me. I only have this question to address. #6002 (comment) |
MrAlias
reviewed
Sep 19, 2024
dashpole
approved these changes
Sep 20, 2024
MrAlias
approved these changes
Oct 3, 2024
dmathieu
approved these changes
Oct 4, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for implementing
OTEL_SEMCONV_STABILITY_OPT_IN
for HTTP client metrics, this is the first PR to emit only old client metrics. This PR will enable us to add the ability for otelhttp to emit both old and new client metrics.Address issue #5973