Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support HeadersList #6657

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Added

- Add support for configuring `ClientCertificate` and `ClientKey` field for OTLP exporters in `go.opentelemetry.io/contrib/config`. (#6378)
- Add support for configuring `HeadersList` field for OTLP exporters in `go.opentelemetry.io/contrib/config`. (#6657)

### Fixed

Expand Down
32 changes: 24 additions & 8 deletions config/v0.3.0/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

"gopkg.in/yaml.v3"

"go.opentelemetry.io/otel/baggage"
"go.opentelemetry.io/otel/log"
nooplog "go.opentelemetry.io/otel/log/noop"
"go.opentelemetry.io/otel/metric"
Expand Down Expand Up @@ -152,14 +153,6 @@ func ParseYAML(file []byte) (*OpenTelemetryConfiguration, error) {
return &cfg, nil
}

func toStringMap(pairs []NameStringValuePair) map[string]string {
output := make(map[string]string)
for _, v := range pairs {
output[v.Name] = *v.Value
}
return output
}

// createTLSConfig creates a tls.Config from certificate files.
func createTLSConfig(caCertFile *string, clientCertFile *string, clientKeyFile *string) (*tls.Config, error) {
tlsConfig := &tls.Config{}
Expand All @@ -186,3 +179,26 @@ func createTLSConfig(caCertFile *string, clientCertFile *string, clientKeyFile *
}
return tlsConfig, nil
}

// createHeadersConfig combines the two header config fields and returns a map[string]string.
func createHeadersConfig(headers []NameStringValuePair, headersList *string) (map[string]string, error) {
result := make(map[string]string)
if headersList != nil {
headerslist, err := baggage.Parse(*headersList)
if err != nil {
return nil, fmt.Errorf("invalid headers list: %w", err)
}
for _, kv := range headerslist.Members() {
result[kv.Key()] = kv.Value()
}
}
// Headers take precedence over HeadersList, so this has to be after HeadersList is processed
if len(headers) > 0 {
for _, kv := range headers {
if kv.Value != nil {
result[kv.Name] = *kv.Value
}
}
}
return result, nil
}
93 changes: 93 additions & 0 deletions config/v0.3.0/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,99 @@ func TestCreateTLSConfig(t *testing.T) {
}
}

func TestCreateHeadersConfig(t *testing.T) {
tests := []struct {
name string
headers []NameStringValuePair
headersList *string
wantHeaders map[string]string
wantErr string
}{
{
name: "no headers",
headers: []NameStringValuePair{},
headersList: nil,
wantHeaders: map[string]string{},
},
{
name: "headerslist only",
headers: []NameStringValuePair{},
headersList: ptr("a=b,c=d"),
wantHeaders: map[string]string{
"a": "b",
"c": "d",
},
},
{
name: "headers only",
headers: []NameStringValuePair{
{
Name: "a",
Value: ptr("b"),
},
{
Name: "c",
Value: ptr("d"),
},
},
headersList: nil,
wantHeaders: map[string]string{
"a": "b",
"c": "d",
},
},
{
name: "both headers and headerslist",
headers: []NameStringValuePair{
{
Name: "a",
Value: ptr("b"),
},
},
headersList: ptr("c=d"),
wantHeaders: map[string]string{
"a": "b",
"c": "d",
},
},
{
name: "headers supersedes headerslist",
headers: []NameStringValuePair{
{
Name: "a",
Value: ptr("b"),
},
{
Name: "c",
Value: ptr("override"),
},
},
headersList: ptr("c=d"),
wantHeaders: map[string]string{
"a": "b",
"c": "override",
},
},
{
name: "invalid headerslist",
headersList: ptr("==="),
wantErr: "invalid headers list: invalid key: \"\"",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
headersMap, err := createHeadersConfig(tt.headers, tt.headersList)
if tt.wantErr != "" {
require.Error(t, err)
require.Equal(t, tt.wantErr, err.Error())
} else {
require.NoError(t, err)
}
require.Equal(t, tt.wantHeaders, headersMap)
})
}
}

func ptr[T any](v T) *T {
return &v
}
16 changes: 12 additions & 4 deletions config/v0.3.0/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,12 @@ func otlpHTTPLogExporter(ctx context.Context, otlpConfig *OTLP) (sdklog.Exporter
if otlpConfig.Timeout != nil && *otlpConfig.Timeout > 0 {
opts = append(opts, otlploghttp.WithTimeout(time.Millisecond*time.Duration(*otlpConfig.Timeout)))
}
if len(otlpConfig.Headers) > 0 {
opts = append(opts, otlploghttp.WithHeaders(toStringMap(otlpConfig.Headers)))
headersConfig, err := createHeadersConfig(otlpConfig.Headers, otlpConfig.HeadersList)
if err != nil {
return nil, err
}
if len(headersConfig) > 0 {
opts = append(opts, otlploghttp.WithHeaders(headersConfig))
}

tlsConfig, err := createTLSConfig(otlpConfig.Certificate, otlpConfig.ClientCertificate, otlpConfig.ClientKey)
Expand Down Expand Up @@ -200,8 +204,12 @@ func otlpGRPCLogExporter(ctx context.Context, otlpConfig *OTLP) (sdklog.Exporter
if otlpConfig.Timeout != nil && *otlpConfig.Timeout > 0 {
opts = append(opts, otlploggrpc.WithTimeout(time.Millisecond*time.Duration(*otlpConfig.Timeout)))
}
if len(otlpConfig.Headers) > 0 {
opts = append(opts, otlploggrpc.WithHeaders(toStringMap(otlpConfig.Headers)))
headersConfig, err := createHeadersConfig(otlpConfig.Headers, otlpConfig.HeadersList)
if err != nil {
return nil, err
}
if len(headersConfig) > 0 {
opts = append(opts, otlploggrpc.WithHeaders(headersConfig))
}

tlsConfig, err := createTLSConfig(otlpConfig.Certificate, otlpConfig.ClientCertificate, otlpConfig.ClientKey)
Expand Down
Loading
Loading