align jaeger probabilistic sampler with traceidratiobased #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the jaegerremotesampler has a custom probabilistic sampler that does not align with how the traceid_ratiobased sampler works. it only looks at the first 64 bits of the trace; the opentelemetry-go sampler looks at the last 64 bits, because there are cases when trace IDs having 64 bits are converted to otel trace IDs, which have 128 bits, and when that happens the first 64 bits are typically ignored/zero-d out. rather than re-implement this logic, this just pulls in the traceid_ratiobased sampler so we re-use it, ensuring the decisions will be made similarly and predictably.
diurnalist
commented
Mar 6, 2025
| @@ -34,26 +35,27 @@ const ( | |||
| testFirstTimeOperationName = "firstTimeOp" | |||
|
|
|||
| testDefaultSamplingProbability = 0.5 | |||
| testMaxID = uint64(1) << 62 | |||
| testMaxID = uint64(1) << 63 | |||
There was a problem hiding this comment.
i think jaeger's old probabilistic sampler only looked at 63 bits
yurishkuro
reviewed
Mar 6, 2025
yurishkuro
reviewed
Mar 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6892 +/- ##
=======================================
- Coverage 76.1% 76.1% -0.1%
=======================================
Files 220 220
Lines 21448 21437 -11
=======================================
- Hits 16332 16321 -11
Misses 4557 4557
Partials 559 559
🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Mar 7, 2025
dmathieu
reviewed
Mar 7, 2025
Co-authored-by: Damien Mathieu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the jaegerremotesampler has a custom probabilistic sampler that does not align with how the traceid_ratiobased sampler works. it only looks at the first 64 bits of the trace; the opentelemetry-go sampler looks at the last 64 bits, because there are cases when trace IDs having 64 bits are converted to otel trace IDs, which have 128 bits, and when that happens the first 64 bits are typically ignored/zero-d out.
rather than re-implement this logic, this just pulls in the traceid_ratiobased sampler so we re-use it, ensuring the decisions will be made similarly and predictably.