-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated config module #6894
Open
mikeblum
wants to merge
3
commits into
open-telemetry:main
Choose a base branch
from
mikeblum:rm-config-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d789ac2
to
a8e55df
Compare
a8e55df
to
47e5dd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6894 +/- ##
=======================================
- Coverage 76.1% 75.5% -0.6%
=======================================
Files 220 207 -13
Lines 21448 19330 -2118
=======================================
- Hits 16332 14606 -1726
+ Misses 4557 4287 -270
+ Partials 559 437 -122 🚀 New features to boost your workflow:
|
47e5dd7
to
666f71d
Compare
codeboten
approved these changes
Mar 6, 2025
@mikeblum are you able to sync with main and move this out of draft state? |
🫡 can do! I left it in draft as I was unsure of the timing of when it
should get merged.
…On Fri, Mar 7, 2025 at 08:29 Tyler Yahn ***@***.***> wrote:
@mikeblum <https://github.com/mikeblum> are you able to sync with main
and move this out of draft state?
—
Reply to this email directly, view it on GitHub
<#6894 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZPN2BKHKZYX57SXXILLD2THCODAVCNFSM6AAAAABYNVKRI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWHA4TCNJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: MrAlias]*MrAlias* left a comment
(open-telemetry/opentelemetry-go-contrib#6894)
<#6894 (comment)>
@mikeblum <https://github.com/mikeblum> are you able to sync with main
and move this out of draft state?
—
Reply to this email directly, view it on GitHub
<#6894 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZPN2BKHKZYX57SXXILLD2THCODAVCNFSM6AAAAABYNVKRI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWHA4TCNJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
With the release fully out, we are at the appropriate time for this to be reviewed and merged. |
a2a77c0
to
d6e810f
Compare
MrAlias
approved these changes
Mar 7, 2025
Cleared to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.