Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated config module #6894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikeblum
Copy link
Contributor

@mikeblum mikeblum commented Mar 6, 2025

No description provided.

@github-actions github-actions bot requested review from codeboten and pellared March 6, 2025 04:07
@mikeblum mikeblum force-pushed the rm-config-module branch 3 times, most recently from d789ac2 to a8e55df Compare March 6, 2025 04:27
@github-actions github-actions bot requested a review from dashpole March 6, 2025 04:28
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (bdfe050) to head (0d8f63e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6894     +/-   ##
=======================================
- Coverage   76.1%   75.5%   -0.6%     
=======================================
  Files        220     207     -13     
  Lines      21448   19330   -2118     
=======================================
- Hits       16332   14606   -1726     
+ Misses      4557    4287    -270     
+ Partials     559     437    -122     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 7, 2025

@mikeblum are you able to sync with main and move this out of draft state?

@mikeblum
Copy link
Contributor Author

mikeblum commented Mar 7, 2025 via email

@MrAlias
Copy link
Contributor

MrAlias commented Mar 7, 2025

With the release fully out, we are at the appropriate time for this to be reviewed and merged.

@mikeblum mikeblum marked this pull request as ready for review March 7, 2025 20:14
@mikeblum mikeblum requested a review from a team as a code owner March 7, 2025 20:14
@mikeblum
Copy link
Contributor Author

mikeblum commented Mar 7, 2025

Cleared to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants