Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv.Array() does not make copy of slice #949

Closed
lizthegrey opened this issue Jul 20, 2020 · 0 comments · Fixed by #1226
Closed

kv.Array() does not make copy of slice #949

lizthegrey opened this issue Jul 20, 2020 · 0 comments · Fixed by #1226
Assignees
Labels
bug Something isn't working pkg:API Related to an API package
Milestone

Comments

@lizthegrey
Copy link
Member

We currently don't freeze the array that we're passed.

This has the potential to result in the naive/least verbose instrumentation doing the wrong thing, if the array that's passed in is mutated after the kv is sent to SetAttributes. This has the potential both to write incorrect data to the span, as well as to introduce a read/write slice concurrent access thread unsafety issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:API Related to an API package
Projects
Archived in project
2 participants