Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update label.ArrayValue to store copies of 1D arrays #1226

Merged
merged 10 commits into from
Oct 6, 2020
Merged

Update label.ArrayValue to store copies of 1D arrays #1226

merged 10 commits into from
Oct 6, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 5, 2020 •
edited
Loading

  • Restrics arrays and slices passed to label.ArrayValue to only include primitives and not support multi-dimensional arrays.
  • Store the ARRAY type Values as arrays.
  • Update the OTLP exporter transform code to support the new storage format of the Values.
  • Minor fixes to label function documentation.

Resolves #949

@MrAlias MrAlias added bug Something isn't working pkg:API Related to an API package release:required-for-ga labels Oct 5, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 5, 2020
@MrAlias MrAlias self-assigned this Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #1226 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1226     +/-   ##
========================================
- Coverage    76.7%   76.6%   -0.1%     
========================================
  Files         133     133             
  Lines        5815    5754     -61     
========================================
- Hits         4463    4412     -51     
+ Misses       1103    1093     -10     
  Partials      249     249
Impacted Files Coverage Δ
exporters/otlp/internal/transform/attribute.go 100.0% <ø> (+6.5%) ⬆️
label/value.go 90.2% <ø> (+1.1%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review October 5, 2020 20:37
@MrAlias MrAlias merged commit 5660b0b into open-telemetry:master Oct 6, 2020
@MrAlias MrAlias deleted the multi-dim-array-label branch October 6, 2020 00:09
@Aneurysm9 Aneurysm9 mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@XSAM XSAM Awaiting requested review from XSAM

Assignees

@MrAlias MrAlias

Labels
bug Something isn't working pkg:API Related to an API package
Projects
None yet
Milestone
RC1
Development

Successfully merging this pull request may close these issues.

kv.Array() does not make copy of slice
3 participants
@MrAlias @Aneurysm9 @lizthegrey