fix(instrumentation-runtime-node): use the correct unit for eventloop…

….utilization (#2631) Co-authored-by: Marc Pichler <[email protected]>
open-telemetry · Jan 9, 2025 · 3350583 · 3350583
1 parent 4cfcc59
commit 3350583
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
@@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {
         `${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`,
         {
           description: 'Event loop utilization',
-          unit: 's',
+          unit: '1',
         }
       )
       .addCallback(async observableResult => {

diff --git a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts
@@ -90,7 +90,7 @@ describe(`${ConventionalNamePrefix.NodeJs}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}
 
     assert.strictEqual(
       utilizationMetric!.descriptor.unit,
-      's',
+      '1',
       'expected default unit'
     );
-Original file line number
+Diff line change
@@ Expand Up @@
         assert.strictEqual(
           utilizationMetric!.descriptor.unit,
-          's',
+          '1',
           'expected default unit'
         );
@@ Expand Down @@