fix(instrumentation-http): skip malformed forwarded headers #5099
+26
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Skips malformed
forwarded
headers instead of throwing an uncaught exception.Fixes #5095
Short description of the changes
Introduce
parseForwardedHeader
inexperimental/packages/opentelemetry-instrumentation-http/src/utils.ts
which wrapsforwarded-parse
and returns an empty array on any caught exception.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
First, wrote a test that broke the instrumentation in the expected way (throwing
ParseError: Unexpected end of input
).Then, fixed it and confirmed the test passes.
Checklist: