feat!: set compilation target to es2022 for all packages but api and semantic-conventions

CHANGELOG.md

@@ -102,6 +102,8 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
   * (user-facing): all configuration previously possible via `window.OTEL_*` is now not supported anymore
     * If you have been using the `envDetector` in browser environments, please migrate to manually creating a resource.
     * Note: Node.js environment variable configuration continues to work as-is.
+* feat!: set compilation target to ES2022 for all packages except `@opentelemetry/api` and `@opentelemetry/semantic-conventions` [#5456](https://github.com/open-telemetry/opentelemetry-js/pull/5456) @david-luna
+  * (user-facing): drops browser runtimes which do not support ES2022 features
 
 ### :rocket: (Enhancement)
 

README.md

@@ -141,9 +141,9 @@ underlying language features used.
 The current minumum language feature support is set as [ECMAScript 2020](https://262.ecma-international.org/11.0/) that are available
 in all modern browsers / runtimes.
 
-This means that if you are targeting or your end-users are using a browser / runtime that does not support ES2020, you will need
+This means that if you are targeting or your end-users are using a browser / runtime that does not support ES2022, you will need
 to transpile the code and provide any necessary polyfills for the missing features to ensure compatibility with your target
-environments. Any support issues that arise from using a browser or runtime that does not support ES2020 will be closed as "won't fix".
+environments. Any support issues that arise from using a browser or runtime that does not support ES2022 will be closed as "won't fix".
 
 This minimum support level is subject to change as the project evolves and as the underlying language features evolve.
 

api/tsconfig.esm.json

@@ -1,8 +1,13 @@
 {
   "extends": "../tsconfig.base.esm.json",
   "compilerOptions": {
+    "lib": [
+      "es2017",
+      "dom"
+    ],
     "outDir": "build/esm",
     "rootDir": "src",
+    "target": "es2017",
     "tsBuildInfoFile": "build/esm/tsconfig.esm.tsbuildinfo"
   },
   "include": [

api/tsconfig.esnext.json

@@ -1,8 +1,13 @@
 {
   "extends": "../tsconfig.base.esnext.json",
   "compilerOptions": {
+    "lib": [
+      "es2017",
+      "dom"
+    ],
     "outDir": "build/esnext",
     "rootDir": "src",
+    "target": "es2017",
     "tsBuildInfoFile": "build/esnext/tsconfig.esnext.tsbuildinfo"
   },
   "include": [

api/tsconfig.json

@@ -1,8 +1,13 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
+    "lib": [
+      "es2017",
+      "dom"
+    ],
     "outDir": "build",
-    "rootDir": "."
+    "rootDir": ".",
+    "target": "es2017"
   },
   "files": [],
   "include": [

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts

@@ -24,6 +24,11 @@ import {
   Attributes,
   DiagConsoleLogger,
 } from '@opentelemetry/api';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
   InMemorySpanExporter,
@@ -70,6 +75,7 @@ import { HttpInstrumentationConfig } from '../../src/types';
 import { assertSpan } from '../utils/assertSpan';
 import { DummyPropagation } from '../utils/DummyPropagation';
 import { httpRequest } from '../utils/httpRequest';
+import { TestMetricReader } from '../utils/TestMetricReader';
 import { ContextManager } from '@opentelemetry/api';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import type {
@@ -84,6 +90,18 @@ import { getRPCMetadata, RPCType } from '@opentelemetry/core';
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
+const memoryExporter = new InMemorySpanExporter();
+const tracerProvider = new NodeTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+
+instrumentation.setTracerProvider(tracerProvider);
+instrumentation.setMeterProvider(meterProvider);
 
 import * as http from 'http';
 import { AttributeNames } from '../../src/enums/AttributeNames';
@@ -99,11 +117,6 @@ const protocol = 'http';
 const hostname = 'localhost';
 const pathname = '/test';
 const serverName = 'my.server.name';
-const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider({
-  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
-});
-instrumentation.setTracerProvider(provider);
 
 function doNock(
   hostname: string,
@@ -342,7 +355,7 @@ describe('HttpInstrumentation', () => {
             return;
           }
           if (request.url?.includes('/ignored')) {
-            provider.getTracer('test').startSpan('some-span').end();
+            tracerProvider.getTracer('test').startSpan('some-span').end();
           }
           if (request.url?.includes('/setroute')) {
             const rpcData = getRPCMetadata(context.active());
@@ -480,7 +493,7 @@ describe('HttpInstrumentation', () => {
         const testPath = '/outgoing/rootSpan/childs/1';
         doNock(hostname, testPath, 200, 'Ok');
         const name = 'TestRootSpan';
-        const span = provider.getTracer('default').startSpan(name);
+        const span = tracerProvider.getTracer('default').startSpan(name);
         return context.with(trace.setSpan(context.active(), span), async () => {
           const result = await httpRequest.get(
             `${protocol}://${hostname}${testPath}`
@@ -523,7 +536,7 @@ describe('HttpInstrumentation', () => {
             httpErrorCodes[i].toString()
           );
           const name = 'TestRootSpan';
-          const span = provider.getTracer('default').startSpan(name);
+          const span = tracerProvider.getTracer('default').startSpan(name);
           return context.with(
             trace.setSpan(context.active(), span),
             async () => {
@@ -565,7 +578,7 @@ describe('HttpInstrumentation', () => {
         const num = 5;
         doNock(hostname, testPath, 200, 'Ok', num);
         const name = 'TestRootSpan';
-        const span = provider.getTracer('default').startSpan(name);
+        const span = tracerProvider.getTracer('default').startSpan(name);
         await context.with(trace.setSpan(context.active(), span), async () => {
           for (let i = 0; i < num; i++) {
             await httpRequest.get(`${protocol}://${hostname}${testPath}`);
@@ -1074,7 +1087,7 @@ describe('HttpInstrumentation', () => {
             return;
           }
           if (request.url?.includes('/ignored')) {
-            provider.getTracer('test').startSpan('some-span').end();
+            tracerProvider.getTracer('test').startSpan('some-span').end();
           }
           if (request.url?.includes('/setroute')) {
             const rpcData = getRPCMetadata(context.active());
@@ -1415,7 +1428,7 @@ describe('HttpInstrumentation', () => {
         });
         instrumentation.enable();
         const testPath = '/test/test';
-        const tracer = provider.getTracer('default');
+        const tracer = tracerProvider.getTracer('default');
         const span = tracer.startSpan('parentSpan', {
           kind: SpanKind.INTERNAL,
         });

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts

@@ -21,17 +21,30 @@ import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import * as assert from 'assert';
 import * as path from 'path';
 import * as url from 'url';
 import { HttpInstrumentation } from '../../src/http';
 import { assertSpan } from '../utils/assertSpan';
 import { DummyPropagation } from '../utils/DummyPropagation';
+import { TestMetricReader } from '../utils/TestMetricReader';
 
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
 
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+instrumentation.setMeterProvider(meterProvider);
+
 import * as http from 'http';
 import * as superagent from 'superagent';
 import * as nock from 'nock';

experimental/packages/opentelemetry-instrumentation-http/test/functionals/https-enable.test.ts

@@ -29,6 +29,11 @@ import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import {
   NETTRANSPORTVALUES_IP_TCP,
   SEMATTRS_HTTP_CLIENT_IP,
@@ -45,11 +50,19 @@ import * as path from 'path';
 import { HttpInstrumentation } from '../../src/http';
 import { assertSpan } from '../utils/assertSpan';
 import { DummyPropagation } from '../utils/DummyPropagation';
+import { TestMetricReader } from '../utils/TestMetricReader';
 import { isWrapped } from '@opentelemetry/instrumentation';
 
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+
+instrumentation.setMeterProvider(meterProvider);
 
 import * as http from 'http';
 import * as https from 'https';

experimental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts

@@ -21,23 +21,35 @@ import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import * as assert from 'assert';
 import * as path from 'path';
 import * as url from 'url';
 import { HttpInstrumentation } from '../../src/http';
 import { assertSpan } from '../utils/assertSpan';
 import { DummyPropagation } from '../utils/DummyPropagation';
+import { TestMetricReader } from '../utils/TestMetricReader';
 
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
+const memoryExporter = new InMemorySpanExporter();
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+instrumentation.setMeterProvider(meterProvider);
 
 import * as http from 'http';
 import * as superagent from 'superagent';
 import * as nock from 'nock';
 import * as axios from 'axios';
 
-const memoryExporter = new InMemorySpanExporter();
 const customAttributeFunction = (span: Span): void => {
   span.setAttribute('span kind', SpanKind.CLIENT);
 };

experimental/packages/opentelemetry-instrumentation-http/test/integrations/esm.test.mjs

@@ -41,15 +41,27 @@ import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 
 import { assertSpan } from '../../build/test/utils/assertSpan.js';
+import { TestMetricReader } from '../../build/test/utils/TestMetricReader.js';
 import { HttpInstrumentation } from '../../build/src/index.js';
 
 const memoryExporter = new InMemorySpanExporter();
 const provider = new NodeTracerProvider({
   spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
 });
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
 const instrumentation = new HttpInstrumentation();
+instrumentation.setMeterProvider(meterProvider);
 instrumentation.setTracerProvider(provider);
 
 const httpImports = [

experimental/packages/opentelemetry-instrumentation-http/test/integrations/http-enable.test.ts

@@ -26,8 +26,14 @@ import * as assert from 'assert';
 import * as url from 'url';
 import { HttpInstrumentation } from '../../src/http';
 import { assertSpan } from '../utils/assertSpan';
+import { TestMetricReader } from '../utils/TestMetricReader';
 import * as utils from '../utils/utils';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
@@ -37,6 +43,13 @@ import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
+const memoryExporter = new InMemorySpanExporter();
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+instrumentation.setMeterProvider(meterProvider);
 
 import * as http from 'http';
 import { httpRequest } from '../utils/httpRequest';
@@ -46,7 +59,6 @@ import { sendRequestTwice } from '../utils/rawRequest';
 
 const protocol = 'http';
 const hostname = 'localhost';
-const memoryExporter = new InMemorySpanExporter();
 
 const customAttributeFunction = (span: Span): void => {
   span.setAttribute('span kind', SpanKind.CLIENT);

experimental/packages/opentelemetry-instrumentation-http/test/integrations/https-enable.test.ts

@@ -34,12 +34,24 @@ import {
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
+import {
+  AggregationTemporality,
+  InMemoryMetricExporter,
+  MeterProvider,
+} from '@opentelemetry/sdk-metrics';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import { HttpInstrumentation } from '../../src';
+import { TestMetricReader } from '../utils/TestMetricReader';
 
 const instrumentation = new HttpInstrumentation();
 instrumentation.enable();
 instrumentation.disable();
+const metricsMemoryExporter = new InMemoryMetricExporter(
+  AggregationTemporality.DELTA
+);
+const metricReader = new TestMetricReader(metricsMemoryExporter);
+const meterProvider = new MeterProvider({ readers: [metricReader] });
+instrumentation.setMeterProvider(meterProvider);
 
 import * as https from 'https';
 import { httpsRequest } from '../utils/httpsRequest';

package.json

@@ -4,7 +4,8 @@
   "description": "OpenTelemetry is a distributed tracing and stats collection framework.",
   "scripts": {
     "precompile": "lerna run version && npm run submodule",
-    "compile": "lerna run protos:generate && tsc --build tsconfig.json tsconfig.esm.json tsconfig.esnext.json",
+    "compile:es2017": "lerna run --scope @opentelemetry/api --scope @opentelemetry/semantic-conventions compile",
+    "compile": "lerna run protos:generate && npm run compile:es2017 && tsc --build tsconfig.json tsconfig.esm.json tsconfig.esnext.json",
     "prewatch": "npm run precompile",
     "watch": "tsc --build --watch tsconfig.json tsconfig.esm.json tsconfig.esnext.json",
     "clean": "tsc --build --clean tsconfig.json tsconfig.esm.json tsconfig.esnext.json",

semantic-conventions/tsconfig.esm.json

@@ -1,8 +1,12 @@
 {
   "extends": "../tsconfig.base.esm.json",
   "compilerOptions": {
+    "lib": [
+      "es2017"
+    ],
     "outDir": "build/esm",
     "rootDir": "src",
+    "target": "es2017",
     "tsBuildInfoFile": "build/esm/tsconfig.esm.tsbuildinfo"
   },
   "include": [

semantic-conventions/tsconfig.esnext.json

@@ -1,8 +1,12 @@
 {
   "extends": "../tsconfig.base.esnext.json",
   "compilerOptions": {
+    "lib": [
+      "es2017"
+    ],
     "outDir": "build/esnext",
     "rootDir": "src",
+    "target": "es2017",
     "tsBuildInfoFile": "build/esnext/tsconfig.esnext.tsbuildinfo"
   },
   "include": [