Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Run all instrumentation tests with multi-instrumentation flag added. #3294

Closed

Conversation

IshwarKanse
Copy link
Contributor

@IshwarKanse IshwarKanse commented Sep 18, 2024

Description:

With changes in PR #3213 we should run all the instrumentation tests with mulit-instrumenation flag added.

Testing:
Tested the PR on OpenShift 4.16 cluster.

@IshwarKanse IshwarKanse requested a review from a team September 18, 2024 06:00
@iblancasa
Copy link
Contributor

Related #3090

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to enable this flag by default? I'm not comfortable having no tests for the default flag values.

@IshwarKanse
Copy link
Contributor Author

@swiatekm @iblancasa I can update this PR once #3302 merges which enables the flag by default.

@iblancasa
Copy link
Contributor

I included this changes in #3302

@IshwarKanse
Copy link
Contributor Author

Closing this one out as the commit is added as part of #3302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants